Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw-tutorial funds #206

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Cw-tutorial funds #206

merged 3 commits into from
Dec 19, 2024

Conversation

jawoznia
Copy link
Contributor

No description provided.

@jawoznia jawoznia requested a review from uint December 11, 2024 15:24
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview ✅ 9 resolved Dec 19, 2024 10:19am

kulikthebird
kulikthebird reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the whole chapter on funds handling. I left comments here and there to consider, but overall I like this change. What's important - I haven't checked the code examples that carefully - are they compiled and tested by vercel?

@jawoznia
Copy link
Contributor Author

Great work! Thanks for the whole chapter on funds handling. I left comments here and there to consider, but overall I like this change. What's important - I haven't checked the code examples that carefully - are they compiled and tested by vercel?

Some of them are, but unfortunately because the tutorial rely on multiple modules it's nearly impossible without creating dozens of templates.

kulikthebird
kulikthebird approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawoznia jawoznia merged commit 6f77cc4 into main Dec 19, 2024
6 checks passed
@jawoznia jawoznia deleted the cw-tutorial/funds branch December 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulikthebird kulikthebird kulikthebird approved these changes

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @kulikthebird